Added a "dispose" method to PhaseLockedVocoder to clear the au wavetable #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| public func dispose() { | ||
| au.setWaveTable([0.0]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -79,7 +79,13 @@ public class PhaseLockedVocoder: Node { | |||
| self.amplitude = amplitude | |||
| self.pitchRatio = pitchRatio | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
The value range is 160.0...1000.0, but the default value was 1500.0 Nothing bad happened because of this, but now it is more correct, with a default value of 1000.0.
aure
requested changes
May 18, 2025
| @@ -114,7 +114,7 @@ public class ZitaReverb: Node { | |||
| identifier: "EQ Frequency 2", | |||
| name: "EQ Frequency 2", | |||
| address: akGetParameterAddress("ZitaReverbParameterEqualizerFrequency2"), | |||
| defaultValue: 1500.0, | |||
| defaultValue: 1000.0, | |||
There was a problem hiding this comment.
Because the default value was not in the value range. It was not a practical problem, but is more correct this way. See this issue: #41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method should be called by the user after they are done with the node.